-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(components): fix tests after Vue3 update #1586
test(components): fix tests after Vue3 update #1586
Conversation
01645ee
to
833d8c6
Compare
e47b975
to
06d765e
Compare
This reverts commit 019f1aa.
48ff6d8
to
e6a2d95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job! 👏
@@ -193,17 +193,15 @@ function mergeStates<State extends Dictionary>( | |||
*/ | |||
export function installNewXPlugin( | |||
options: Partial<XPluginOptions> = {}, | |||
localVue = undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove the localVue parameter from the jsdoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job cleaning up Vue 2 style!
Motivation and context
First batch of fixed unit test from
packages/x-components/src/components/__tests__
after Vue3 upgrade.Type of change
What is the destination branch of this PR?
Main
How has this been tested?
Tests performed according to testing guidelines:
Checklist: