Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(components): fix tests after Vue3 update #1586

Merged
merged 12 commits into from
Aug 9, 2024

Conversation

victorcg88
Copy link
Contributor

Motivation and context

First batch of fixed unit test from packages/x-components/src/components/__tests__ after Vue3 upgrade.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@victorcg88 victorcg88 changed the title feat(x-installer): update to vue3 and adapt x-installer (#1572) test(components): fix tests after Vue3 update BATCH 1 Aug 6, 2024
@victorcg88 victorcg88 force-pushed the test/fix-auto-progress-bar branch 4 times, most recently from 01645ee to 833d8c6 Compare August 7, 2024 08:38
@victorcg88 victorcg88 force-pushed the test/root-components-refactor-batch1 branch from e47b975 to 06d765e Compare August 7, 2024 10:51
@victorcg88 victorcg88 changed the title test(components): fix tests after Vue3 update BATCH 1 test(components): fix tests after Vue3 update Aug 7, 2024
@victorcg88 victorcg88 changed the base branch from test/fix-auto-progress-bar to vue3-update-rc August 7, 2024 14:37
@victorcg88 victorcg88 force-pushed the test/root-components-refactor-batch1 branch from 48ff6d8 to e6a2d95 Compare August 7, 2024 14:37
@victorcg88 victorcg88 marked this pull request as ready for review August 7, 2024 14:57
@victorcg88 victorcg88 requested a review from a team as a code owner August 7, 2024 14:57
Copy link
Contributor

@diegopf diegopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job! 👏

@@ -193,17 +193,15 @@ function mergeStates<State extends Dictionary>(
*/
export function installNewXPlugin(
options: Partial<XPluginOptions> = {},
localVue = undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove the localVue parameter from the jsdoc

Copy link
Member

@joseacabaneros joseacabaneros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job cleaning up Vue 2 style!

@joseacabaneros joseacabaneros merged commit 5d4dec8 into vue3-update-rc Aug 9, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants